integration tests: sync suite between GHA and entrypoint#12703
Merged
Maffooch merged 3 commits intoJun 30, 2025
Conversation
|
No security concerns detected in this pull request. All finding details can be found in the DryRun Security Dashboard. |
Open
3 tasks
Maffooch
approved these changes
Jun 30, 2025
dogboat
approved these changes
Jun 30, 2025
hblankenship
approved these changes
Jun 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the integration test suite in GHA and the container entrypoint were slightly out of sync.
Turns out two of the newly or readded test suites were failing:
close_old_findings_dedupe_test: a leftover from Ruff PRs caused a type mismatchfalse_positive_history_test: the implemented logic doesn't support marking a false positive finding as "not false positive" again as long as there are other false positive findings with the same hash_code. I provided my comment on the issue that reported this: Cant re-activate Inactive, Mitigated, False Positive finding: test_retroactive_edit_finding #8977 (comment)